RFR: 8274300: Address dsymutil warning by excluding platform specific files
David Holmes
dholmes at openjdk.org
Tue Jan 9 07:53:30 UTC 2024
On Mon, 8 Jan 2024 20:16:47 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> We run dsymutils on the libraries (e.g. `libjvm.dylib`) to extract the debug symbols.
So how does it know about empty files??? Does an empty src file create an empty object file which in turns creates an empty section in the library?
>> make/test/JtregNativeHotspot.gmk line 862:
>>
>>> 860: ifeq ($(call And, $(call isTargetOs, linux) $(call isTargetCpu, aarch64)), false)
>>> 861: BUILD_HOTSPOT_JTREG_EXCLUDE += libTestSVEWithJNI.c
>>> 862: endif
>>
>> I would have put this inside the existing Linux section ie move to before the endif at line 858, and then just check for aarch64.
>
> It's the other way around - this test is excluded for all platforms _but_ linux-aarch64 (note the `false`).
Ah - sorry.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17287#issuecomment-1882560938
PR Review Comment: https://git.openjdk.org/jdk/pull/17287#discussion_r1445732213
More information about the build-dev
mailing list