RFR: 8322757: Enable -Wparentheses warnings
Kim Barrett
kbarrett at openjdk.org
Wed Jan 10 02:04:33 UTC 2024
Please review this change to enable -Wparentheses when building HotSpot. That
warning is enabled by -Wall (which we use). That was overridden by explicitly
disabling it, because there were a number of places in HotSpot code that
triggered such warnings. Those places have all been fixed. In some cases that
made the code perhaps a little easier to read. There were also a few bugs
found and fixed by that effort. (So -Wparentheses has found existing bugs, and
may prevent future bugs.)
Testing: mach5 tier1 and GHA sanity checks, to provide build coverage for
Oracle-supported platforms and community-supported platforms.
-------------
Commit messages:
- remove disable of -Wparentheses
Changes: https://git.openjdk.org/jdk/pull/17335/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17335&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8322757
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/17335.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17335/head:pull/17335
PR: https://git.openjdk.org/jdk/pull/17335
More information about the build-dev
mailing list