RFR: 8318696: Do not use LFS64 symbols on Linux

Magnus Ihse Bursie ihse at openjdk.org
Thu Jan 11 12:11:23 UTC 2024


On Tue, 24 Oct 2023 01:36:32 GMT, Sam James <duke at openjdk.org> wrote:

> The LFS64 symbols provided by glibc are not part of any standard and were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). This commit replaces the usage of LFS64 symbols with their regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions will always act as their -64 variants on glibc.

>From a build perspective, this looks sane. 

It is okay to start with making sure Hotspot is fully FOB64 before looking at the rest of the JDK libraries, but it would be good if those too eventually were addressed.

This has been a neglected issue for some time, so I'm happy to see that it gets some attention. 

Note that the hotspot parts still require two Hotspot reviewers.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16329#pullrequestreview-1815397286


More information about the build-dev mailing list