RFR: 8314488: Compile the JDK as C++17 [v5]

Magnus Ihse Bursie ihse at openjdk.org
Thu Jan 11 12:25:27 UTC 2024


On Thu, 11 Jan 2024 11:33:07 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary -std=c++17 option in Lib.gmk
>
> Regarding https://github.com/TheShermanTanker/jdk/actions/runs/7070564987/job/19247370401, could it be that the adlc build didn't get the correct C++ version flags? It doesn't look like a clang 13 specific problem.

@TheRealMDoerr 

> The only issue I see is requiring clang 14.0 on MacOS is not in sync with "Other JDK 22 build platforms" (https://wiki.openjdk.org/display/Build/Supported+Build+Platforms).

That page is suppose to document what we actually do, not be a binding contract; so if we change stuff, we update the page to reflect it, rather than the other way around. 

Or maybe I misunderstood your comment?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14988#issuecomment-1887044785


More information about the build-dev mailing list