RFR: JDK-8298405: Support Markdown in Documentation Comments [v6]

Pavel Rappo prappo at openjdk.org
Thu Jan 11 15:10:29 UTC 2024


On Wed, 8 Nov 2023 16:24:20 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge with upstream/master
>>  - Merge remote-tracking branch 'upstream/master' into 8298405.doclet-markdown-v3
>>  - Address review comments
>>  - Fix whitespace
>>  - Improve handling of embedded inline taglets
>>  - Customize support for Markdown headings
>>  - JDK-8298405: Support Markdown in Documentation Comments
>
> test/langtools/tools/javac/classfiles/attributes/deprecated/DeprecatedTest.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @bug 8042261 8298405
> 
> This comment is not for this line, but for two compiler tests for `@deprecated` javadoc tag. It seemed quite contextual place to put it.
> 
> Did I miss it, or you are planning to add a javadoc test that verifies that `@deprecated` appearing in a `///` comment has no [special meaning] it has in classic `/** */` comments?
> 
> [special meaning]: https://github.com/openjdk/jdk/blob/128363bf3b57dfa05b3807271b47851733c1afb9/src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java#L1639-L1653

Ping. I do believe that it's important to have such a test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1449001056


More information about the build-dev mailing list