RFR: JDK-8320458: Improve structural navigation in API documentation [v2]
Hannes Wallnöfer
hannesw at openjdk.org
Thu Jan 11 15:13:28 UTC 2024
On Tue, 9 Jan 2024 23:44:51 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template line 33:
>
>> 31: loading: "##REPLACE:doclet.search.loading##",
>> 32: searching: "##REPLACE:doclet.search.searching##",
>> 33: redirecting: "##REPLACE:doclet.search.redirecting##",
>
> Suggestion ...
> Would it make sense to "minimize" the use of templates by moving all the template-y stuff to a single template file, that can be included by the other JavaScript files, which would then become "normal" JavaScript `.js` files.
That's something we should consider. We could use `script.js` for this as it is the first loaded script file, therefore available in all other script files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17062#discussion_r1449005491
More information about the build-dev
mailing list