RFR: 8323667: Library debug files contain non-reproducible full gcc include paths [v2]

[Magnus Ihse Bursie]

On Tue, 16 Jan 2024 13:28:31 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> make/autoconf/flags-cflags.m4 line 194:
>> 
>>> 192:     # Add gcc system include mapping => /usr/local/gcc_include
>>> 193:     #   Find location of stddef.h using build C compiler
>>> 194:     GCC_SYSTEM_INCLUDE=`$ECHO "#include <stddef.h>" | $CC $GCC_SYSROOT_PARAM -v -E - 2>&1 | $GREP stddef | $TAIL -1 | $TR -s " " | $CUT -d'"' -f2`
>> 
>> Don't we have a properly setup `CFLAGS` here that you can use, instead of having to specify the sysroot manually?
>
> Yeah, you're right, SYSROOT_CFLAGS

Actually, I meant the literal value `CFLAGS`, as in `$CC $CFLAGS`. We do not use it in the build, but autoconf uses it in the test macros it provides that we utilize, so we have to make sure it is set "good enough" to at least get the compiler to run, which at least means setting the sysroot.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17399#discussion_r1453452025