RFR: 8323667: Library debug files contain non-reproducible full gcc include paths [v2]

[Andrew Leonard]

On Tue, 16 Jan 2024 13:58:51 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> @magicus  Yes, good point the condition is sort of hidden as it is.
>> I've moved the DEBUG_PREFIX_MAP_GCC_INCLUDE_PATHS setting prior to the compiler option check, so the whole constructed DEBUG_PREFIX_CFLAGS is verified, which is probably how it should be.
>> 
>> Updated... What do you think?
>
> Hmm, i'm not sure, it makes the configure output a bit noisy:
> 
> checking if CC supports "-fdebug-prefix-map=/home/andrew/temurin-build/workspace/build/src/= -fdebug-prefix-map=/home/andrew/jdk21u/build/devkit/result/aarch64-linux-gnu-to-aarch64-linux-gnu/aarch64-linux-gnu/sysroot/usr/include/=/usr/include/ -fdebug-prefix-map=/home/andrew/jdk21u/build/devkit/result/aarch64-linux-gnu-to-aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/11.3.0/include/=/usr/local/gcc_include/ -fdebug-prefix-map=/home/andrew/jdk21u/build/devkit/result/aarch64-linux-gnu-to-aarch64-linux-gnu/include/c++/11.3.0/=/usr/local/gxx_include/"... yes
> 
> I'll try moving DEBUG_PREFIX_MAP_GCC_INCLUDE_PATHS to IF_TRUE instead

yes, that looks better I think.
What you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17399#discussion_r1453477985