RFR: 8323675: Race in jdk.javadoc-gendata

[Erik Joelsson]

On Mon, 15 Jan 2024 12:32:35 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> make/Main.gmk line 975:
>> 
>>> 973:   # It needs all generated java code present.
>>> 974:   jdk.compiler-gendata: $(JAVA_TARGETS)
>>> 975:   jdk.javadoc-gendata: $(JAVA_TARGETS)
>> 
>> The comment talks about source code, but this is adding JAVA_TARGETS which is all compiled classes. Is the tool operating on source code or on class files?
>
> I think it might operate on both, but I'm not sure. But my thinking was that JAVA_TARGETS depended on GENSRC_TARGETS, which in turn would make sure that all source code was properly generated.
> 
> Am I missing something?

Unnecessarily depending on too much hurts build performance. I would like @lahodaj to help us understand what the tool actually needs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17402#discussion_r1453864860