RFR: 8323672: Suppress unwanted autoconf added flags in CC and CXX [v3]

Julian Waters jwaters at openjdk.org
Wed Jan 17 12:44:53 UTC 2024


On Wed, 17 Jan 2024 12:08:18 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted autoconf flags being added to the command line, and solves the issue by filtering out the added flags by force. This is not optimal however, as doing so leaves the autoconf message that the flags were added still displaying during the configure process, which is confusing. Instead, setting a couple of fields to disable the autoconf internals responsible for the unwanted flag is a cleaner solution
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-13
>  - Revert toolchain.m4
>  - make/autoconf/toolchain.m4
>    
>    Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
>  - 8323672

Out of curiosity: What exactly does AC_PROG_CC do that we need? I've begun writing a modified version of it, and I'm shocked with how much can be completely stripped away from the new version, and am unsure if I'm eliminating parts of it that we actually need

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17401#issuecomment-1895732855


More information about the build-dev mailing list