RFR: 8323675: Race in jdk.javadoc-gendata

Erik Joelsson erikj at openjdk.org
Wed Jan 17 19:16:50 UTC 2024


On Wed, 17 Jan 2024 19:10:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> This tool only uses sources, it will not use the compiled classfiles. So, running it at a point where all sources are generated should be sufficient. Most important are generated module-infos, but other sources may in some cases be significant as well.
>
> Thanks, in that case I think both of these should be depending on `$(GENSRC_TARGETS)` instead.

I take that back, jdk.javadoc-gendata should depend on `$(GENSRC_TARGETS)`, jdk.compiler-gendata still needs `$(JAVA_TARGETS)` as the recipe for that target seems to actually use compiled classes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17402#discussion_r1456347303


More information about the build-dev mailing list