RFR: 8318696: Do not use LFS64 symbols on Linux [v2]

David Holmes dholmes at openjdk.org
Fri Jan 19 06:12:28 UTC 2024


On Fri, 19 Jan 2024 06:08:21 GMT, Sam James <duke at openjdk.org> wrote:

>> The LFS64 symbols provided by glibc are not part of any standard and were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). This commit replaces the usage of LFS64 symbols with their regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions will always act as their -64 variants on glibc.
>
> Sam James has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add off_t static_asserts
>   
>   Signed-off-by: Sam James <sam at gentoo.org>

Thanks, update seems fine.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16329#pullrequestreview-1831637139


More information about the build-dev mailing list