RFR: 8318696: Do not use LFS64 symbols on Linux [v3]

[Sam James]

On Fri, 19 Jan 2024 10:06:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Sam James has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add message for assert
>>   
>>   Not all C++ stds implement it w/o.
>
> src/hotspot/os/linux/os_linux.cpp line 4252:
> 
>> 4250: // otherwise, returns -1 that implies an error
>> 4251: jlong os::Linux::sendfile(int out_fd, int in_fd, jlong* offset, jlong count) {
>> 4252:   return ::sendfile64(out_fd, in_fd, (off_t*)offset, (size_t)count);
> 
> Why is this continuing to use sendfile64, rather than sendfile?

oh, great spot! I'll take you up on the recommendation for banning the *64 functions in one of the followups.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16329#discussion_r1458756249