RFR: 8318696: Do not use LFS64 symbols on Linux [v5]

Sam James duke at openjdk.org
Fri Jan 19 23:50:46 UTC 2024


> The LFS64 symbols provided by glibc are not part of any standard and were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in 1.2.5). This commit replaces the usage of LFS64 symbols with their regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions will always act as their -64 variants on glibc.

Sam James has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge master
 - crank copyright
 - sendfile64 -> sendfile
   
   Signed-off-by: Sam James <sam at gentoo.org>
 - buf64->buf
   
   Signed-off-by: Sam James <sam at gentoo.org>
 - Add message for assert
   
   Not all C++ stds implement it w/o.
 - Add off_t static_asserts
   
   Signed-off-by: Sam James <sam at gentoo.org>
 - Do not use LFS64 symbols on Linux
   
   The LFS64 symbols provided by glibc are not part of any standard and
   were gated behind -D_LARGEFILE64_SOURCE in musl 1.2.4 (to be removed in
   1.2.5). This commit replaces the usage of LFS64 symbols with their
   regular counterparts and defines -D_FILE_OFFSET_BITS=64, ensuring that functions
   will always act as their -64 variants on glibc.
   
   Signed-off-by: Sam James <sam at gentoo.org>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16329/files
  - new: https://git.openjdk.org/jdk/pull/16329/files/5a66616f..29e5c55f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16329&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16329&range=03-04

  Stats: 46198 lines in 1358 files changed: 28040 ins; 12096 del; 6062 mod
  Patch: https://git.openjdk.org/jdk/pull/16329.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16329/head:pull/16329

PR: https://git.openjdk.org/jdk/pull/16329


More information about the build-dev mailing list