RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16

[Magnus Ihse Bursie]

On Thu, 25 Jan 2024 14:48:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Current GHA runs produce lots of warnings:
> 
> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache at v3, actions/download-artifact at v3, actions/upload-artifact at v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
> 
> We can upgrade to new actions to get the Node20.
> 
> Release/migration notes:
> https://github.com/actions/cache#whats-new
> https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md
> https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md
> https://github.com/actions/github-script#breaking-changes
> 
> There is also msys2/setup-msys2, which was pinned by [JDK-8310259](https://bugs.openjdk.org/browse/JDK-8310259). We need at least 2.21.0 to get Node 20:
> https://github.com/msys2/setup-msys2/blob/main/CHANGELOG.md. I think we can unpin msys2 at this point.
> 
> I don't think any of the migration problems outlined in those notes apply to our workflows.
> 
> Additional testing:
>  - [x] 3x GHA with cleaned caches
>  - [ ]  3x GHA with populated caches (default)

Thanks for looking into this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17572#issuecomment-1911801515