RFR: 8323621: JDK build should exclude snippet class in java.lang.foreign [v2]

[Per Minborg]

On Mon, 15 Jan 2024 13:27:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> If possible, we should simply exclude all files in directories that have `-` (minus sign) in their name; this is the intentional design to prevent javac from compiling those classes as package names cannot include `-`.
>
> I agree that this piecemeal approach is not good. I think there is a JBS enhancement request to filter all "snippet-files" and "javadoc-files" everywhere. But maybe we can make it broader? Filtering on just `-` makes me a bit nervous though; it seems like it could unintentionally break at some point. But maybe filter out all `-files`?

It would be good if snippets were compiled (so that the syntax and correctness are ensured) but not included in shipped artifacts.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17403#discussion_r1469634458