RFR: JDK-8298405: Support Markdown in Documentation Comments [v6]
Jonathan Gibbons
jjg at openjdk.org
Mon Jan 29 23:07:38 UTC 2024
On Fri, 12 Jan 2024 15:20:56 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>>
>> - Merge with upstream/master
>> - Merge remote-tracking branch 'upstream/master' into 8298405.doclet-markdown-v3
>> - Address review comments
>> - Fix whitespace
>> - Improve handling of embedded inline taglets
>> - Customize support for Markdown headings
>> - JDK-8298405: Support Markdown in Documentation Comments
>
> src/jdk.compiler/share/classes/com/sun/source/util/DocTreeFactory.java line 303:
>
>> 301: * @since 22
>> 302: */
>> 303: RawTextTree newRawTextTree(DocTree.Kind kind, String code) throws IllegalArgumentException;
>
> It's unusual for a JDK method to declare a runtime exception.
removed; there is an `@throws` for the exception; that is enough
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1470342549
More information about the build-dev
mailing list