RFR: JDK-8298405: Support Markdown in Documentation Comments [v6]
Jonathan Gibbons
jjg at openjdk.org
Tue Jan 30 00:42:47 UTC 2024
On Fri, 19 Jan 2024 11:38:56 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>>
>> - Merge with upstream/master
>> - Merge remote-tracking branch 'upstream/master' into 8298405.doclet-markdown-v3
>> - Address review comments
>> - Fix whitespace
>> - Improve handling of embedded inline taglets
>> - Customize support for Markdown headings
>> - JDK-8298405: Support Markdown in Documentation Comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java line 259:
>
>> 257: LineKind lineKind = textKind == DocTree.Kind.MARKDOWN ? peekLineKind() : null;
>> 258:
>> 259: if (DEBUG) System.err.println("starting content " + showPos(bp) + " " + newline);
>
> Debug output is useful. I wonder if we should consider https://openjdk.org/jeps/264.
My oops for leaving the code in, or at least not cleaning it up more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1470424344
More information about the build-dev
mailing list