RFR: 8324539: Do not use LFS64 symbols in JDK libs [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Jan 30 12:56:45 UTC 2024
On Mon, 29 Jan 2024 14:04:15 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Restore AIX dirent64 et al defines
>
> src/java.base/share/native/libjli/wildcard.c line 109:
>
>> 107: return _access(filename, 0) == 0;
>> 108: #else
>> 109: return access(filename, F_OK) == 0;
>
> You have to keep these defines for AIX, because _LARGE_FILES does not act on them, but instead of
> `#if defined(_AIX)`
> you could use
> `#if defined(_AIX) && defined(_LARGE_FILES)`
I've restored all changes to the dir64 functions. Annoying that they are not included in `_LARGE_FILES`. :( The "fix for AIX" define block is also copied in multiple places; I tried to see if I could find a common place to put them once and then include it, but there was no obvious such spot, so I just left them in place.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17538#discussion_r1471159703
More information about the build-dev
mailing list