RFR: 8324539: Do not use LFS64 symbols in JDK libs

Magnus Ihse Bursie ihse at openjdk.org
Tue Jan 30 13:05:34 UTC 2024


On Tue, 30 Jan 2024 08:18:39 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK native libraries.
>
> AIX fastdebug build fails with the patch, build error is
> 
> 
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-dbg/jdk/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c:101:24: error: no member named 'open64' in 'SpanIteratorFuncs'; did you mean 'open'?
>     srData = (*pFuncs->open)(env, si);
>                        ^~~~
>                        open
> /usr/include/fcntl.h:115:14: note: expanded from macro 'open'
> #define open    open64
>                 ^
> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-dbg/jdk/src/java.desktop/share/native/libawt/java2d/pipe/SpanIterator.h:37:17: note: 'open' declared here
>     void     *(*open)(JNIEnv *env, jobject iterator);

@MBaesken You gotta be kidding me... They just put in a `#define open open64` in a convenient place? 😞 

But why do only slowdebug fail? Weird.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1916799251


More information about the build-dev mailing list