RFR: 8324539: Do not use LFS64 symbols in JDK libs [v2]

Magnus Ihse Bursie ihse at openjdk.org
Tue Jan 30 13:08:41 UTC 2024


On Tue, 30 Jan 2024 12:52:56 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK native libraries.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore AIX dirent64 et al defines

Ok, at least I know why debug fails. `BufferedRenderPipe.c` includes `Trace.h` which include `debug_trace.h`, which includes `debug_util.h` -- but only if `DEBUG` is defined.

`debug_util.h` in turn includes <stdlib.h>, <stdio.h> and some other system headers, some of which presumably drags along `fcntl.h` with it overly broad redefine of "open".

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1916804593


More information about the build-dev mailing list