RFR: 8324539: Do not use LFS64 symbols in JDK libs [v4]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Jan 30 16:17:08 UTC 2024
On Tue, 30 Jan 2024 14:15:57 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK native libraries.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into jdk-FOB64
> - Move #include <stdlib/io.h> out of debug_util.h
> - Restore AIX dirent64 et al defines
> - Rollback AIX changes since they are now tracked in JDK-8324834
> - Remove superfluous setting of FOB64
> - Replace all foo64() with foo() for large-file functions in the JDK
> - 8324539: Do not use LFS64 symbols in JDK libs
Now I realize what happened. Skara didn't set proper labels since most of the files were touched in the second commit, not the first...
I hope I didn't miss any...
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1917029488
More information about the build-dev
mailing list