RFR: JDK-8325004: Support a "table-of-contents" for some Markdown spec docs

Jonathan Gibbons jjg at openjdk.org
Wed Jan 31 17:22:01 UTC 2024


On Wed, 31 Jan 2024 10:24:44 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Yeah, right, make sure you have the following block in your md file:
> 
> ```
> ---
> # Copyright (c) 1993, 2023, Oracle and/or its affiliates. All rights reserved.
> ...
> _pandoc-options_: --toc
> ---
> ```

Wow; will try that!

> make/Docs.gmk line 662:
> 
>> 660:             DEST := $(DOCS_OUTPUTDIR)/specs/, \
>> 661:             CSS := $(GLOBAL_SPECS_DEFAULT_CSS_FILE), \
>> 662:             OPTIONS := $($m_$(notdir $f)_TOC) -V include-before='$(SPECS_TOP)' -V include-after='$(SPECS_BOTTOM_$($m_$f_NOF_SUBDIRS))', \
> 
> I'd like you to calculate a variable for this, a few lines above (can't mark it in github review mode 😞), like:
> 
>         $(eval $m_$f_OPTIONS := $($m_$(notdir $f)_OPTIONS) \
> 
> 
> and then use that variable instead in the OPTIONS line.

Thanks for the advice; will do.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17642#issuecomment-1919559496
PR Review Comment: https://git.openjdk.org/jdk/pull/17642#discussion_r1473182561


More information about the build-dev mailing list