RFR: 8325369: @sealedGraph: Bad link to image for tag on nested classes

[Jonathan Gibbons]

On Wed, 10 Jul 2024 18:57:22 GMT, Chen Liang <liach at openjdk.org> wrote:

> Fixes the link to the generated sealed graph svg generated by the sealed graph taglet.
> 
> Affected interfaces includes [`ClassFile.Option`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lang/classfile/ClassFile.Option.html) ([before](https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/ClassFile.Option.html)), [`AnnotationValue.OfConstant`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lang/classfile/AnnotationValue.OfConstant.html) ([before](https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/AnnotationValue.OfConstant.html)), a few [nested interfaces](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lang/classfile/Signature.html#nested-class-summary) in `Signature` ([original](https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/Signature.html#nested-class-summary)), and [`TypeAnnotaton.TargetInfo`](https://cr.openjdk.org/~nbena
 lla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lang/classfile/TypeAnnotation.TargetInfo.html) ([before](https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/TypeAnnotation.TargetInfo.html)).
> 
> Courtesy to @nizarbenalla for hosting the updated doc rendering.

Approved, with an optional suggestion

make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 324:

> 322:         while (element.getNestingKind() == NestingKind.MEMBER) {
> 323:             element = (TypeElement) element.getEnclosingElement();
> 324:             result = element.getSimpleName().toString() + '.' + result;

This would be slightly simpler as `element.getSimpleName() + "." + result`

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20122#pullrequestreview-2170436370
PR Review Comment: https://git.openjdk.org/jdk/pull/20122#discussion_r1673091121