Integrated: 8324966: Allow selecting jtreg test case by ID from make
Axel Boldt-Christmas
aboldtch at openjdk.org
Thu Jul 11 08:20:59 UTC 2024
On Mon, 1 Jul 2024 06:49:15 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> [JDK-8287828](https://bugs.openjdk.org/browse/JDK-8287828) added support for selecting specific JTREG tests cases by their ID. However because of how we handle input strings in make it was not possible to use `#` anywhere, breaking this feature.
>
> Prior to this change
> * `TEST="gc/TestSystemGC.java#Serial gc/TestSystemGC.java#G1" make test` Works.
> * `make test TEST="gc/TestSystemGC.java#Serial gc/TestSystemGC.java#G1"` Does not work.
>
> After this change both works.
>
> When propagating command line variables through the make system we transiently replaced spaces with `#` (which drops any actual `#` when restoring the spaces). This patch replaced the `#` character with `§` under the assumption that it will not be used in these arguments.
>
> This works for now. An alternative would be to make this more robust by selecting a sequence of characters that is checked to not be part of the strings in question as the space placeholder. But I will leave that to our more advance Make engineers to handle.
This pull request has now been integrated.
Changeset: 2928753b
Author: Axel Boldt-Christmas <aboldtch at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2928753bd95356467e4fe42ee391e45d1cb6e89c
Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
8324966: Allow selecting jtreg test case by ID from make
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/jdk/pull/19963
More information about the build-dev
mailing list