RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v11]

fitzsim duke at openjdk.org
Tue Jul 23 13:57:36 UTC 2024


On Fri, 19 Jul 2024 09:18:13 GMT, Andrew Haley <aph at openjdk.org> wrote:

> Compared to current implementation in #19185, my bit concern about [This branch](https://github.com/fitzsim/jdk/commits/regenerate-sleef-headers-1/) is the future maintainence effort when we need to update the sleef source along with the cmake changes, also when new platforms support of sleef are added in jdk.

To check this, I [added](https://github.com/fitzsim/jdk/commits/regenerate-sleef-headers-2/) the `riscv64` `CMake` steps to `SleefCommon.gmk`.

I had intended to factor out `SetupSleefHeader` anyway for `aarch64`, to eliminate copy-n-paste.

After that, there was one build step divergence for `riscv64` for the naming of the helper header.

The two `riscv64` commits are:

- [copy `helperrvv.h`](https://github.com/fitzsim/jdk/commit/bcd3813ca97f6308838ee93bcb5c02d9cd37375a)
- [add `riscv64` support to `SleefCommon.gmk`](https://github.com/fitzsim/jdk/commit/21e0369682095422f45015d817410d07c711b8c0)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2245327294


More information about the build-dev mailing list