RFR: 8336343: Add more known sysroot library locations for ALSA
Phil Race
prr at openjdk.org
Sun Jul 28 22:17:31 UTC 2024
On Sat, 13 Jul 2024 16:48:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Following [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), it would be more convenient to search into more paths in sysroot for ALSA as well. Currently, this is the only thing that is missing for me to build from the crosstool-ng generated sysroot. Without these, we have to provide the additional `--with-alsa-lib` configuration param.
>
> We do a similar thing for X11: https://github.com/openjdk/jdk/blob/6f325db49365d3d06add5d194d4696a1428675fa/make/autoconf/lib-x11.m4#L55-L79
>
> Additional testing:
> - [x] JDK mainline builds with the patch and crosstool-ng without problems now
> - [x] GHA
> - [x] A matrix of Server/Zero builds with GCC 10
This looks reasonable to me, but someone from the build team
(specifically @magicus or @erikj79) should approve as well.
-------------
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20173#pullrequestreview-2203599673
More information about the build-dev
mailing list