RFR: 8336342: Fix known X11 library locations in sysroot

Phil Race prr at openjdk.org
Sun Jul 28 22:20:31 UTC 2024


On Sat, 13 Jul 2024 13:43:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> In [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), we added the search paths for X11 libraries, but they point explicitly to `libX11.so`. First, this is not really correct, as `x_libraries` would be added to a search path. Second, this apparently does not work for sysroots created by crosstool-ng, likely because it wants to find other libraries in the same location. Debootstrap-ed GHA seem to work because they find the X11 libraries before hitting this code, apparently.
> 
> We should just drop the `libX11.so` parts, and leave only the path.
> 
> Additional testing:
>  - [x] JDK 23, 21, 17, 11 builds with the patch and crosstool-ng without problems now
>  - [x] GHA
>  - [x] A matrix of Server/Zero builds with GCC 10

This is marked as an enhancement but it sure looks like a bug fix to me.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20170#pullrequestreview-2203600025


More information about the build-dev mailing list