RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

[Lutz Schmidt]

On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

> On MacOS, files may have extended attributes attached. These attributes are copied together with the files. To prevent issues during further processing, the extended attributes of the copies must be removed. This action was implemented as solution of an older bug.
> 
> The solution is incomplete because it does not handle files with read-only permissions correctly. Without write permission, matter cannot remove the extended attributes. The action is rejected with a "permission denied" error.
> 
> The issue is present in all releases. I reproduced it in 11, 17, ... 23, head
> 
> The solution is to "chmod u+w" only those files which need to have their extended attributes removed.
> 
> Backport note: in releases prior to jdk23, the change needs to go into file MakeBase.gmk.
> 
> Testing @SAP completed without any related issues.

Any new opinion on this PR? From the build people, for example?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20203#issuecomment-2257744448