RFR: 8319457: Update jpackage to support WiX Toolset 4 on Windows

Victor Dyakov vdyakov at openjdk.org
Tue Jun 4 01:40:31 UTC 2024


On Mon, 20 May 2024 21:14:09 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Add support for WiX4 (and WiX5) in jpackage.
> 
> jpackage supports WiX3, WiX4 and WiX5. It will pick WiX4/WiX5 if one of them is installed and there is WiX3 installed too. (Note: WiX4 and WiX5 are not supposed to be installed side-by-side, but if it happens, WiX5 will be preferred over WiX4).
> 
> Custom WiX3 sources will be automatically converted to WiX4 format if WiX4/WiX5 is used. The converter provides:
> 
> - full support of the conversion of WiX L10N (.wxl) files, i.e. full support of "http://schemas.microsoft.com/wix/2006/localization" to "http://wixtoolset.org/schemas/v4/wxl" namespace conversion;
> - partial support of WiX source (.wxs) files, i.e. partial support of "http://schemas.microsoft.com/wix/2006/wi" to "http://wixtoolset.org/schemas/v4/wxs" namespace conversion;
> 
> The converter is a XSLT stylesheet. The default converter is `src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/wix3-to-wix4-conv.xsl`. It can be replaced with the custom converter by adding "wix-conv.xsl" file to the resource directory.

as we previously agreed this is for JDK 24 (mainline is becoming JDK 24 after 10am PT on Thu June 6) just do not jeopardize  by any kind of risks on stabilization part with all tests run cycle, so good to integrate once it is reviewed and approved after June 6th

WiX v5 for WiX v4 users

WiX v5 is highly compatible with WiX v4. WiX v5 continues in the traditions of WiX v4 and is available as both a .NET tool and an MSBuild SDK. The WiX v5 language uses the same XML namespace as WiX v4 and -- with a couple of exceptions -- is backward compatible with the WiX v4 language. That means that you don't need to translate your WiX v4 projects to use WiX v5.
https://wixtoolset.org/docs/fivefour/

So this is a good point to make it working with WiX 5 (not just WiX 4)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19318#issuecomment-2146401059
PR Comment: https://git.openjdk.org/jdk/pull/19318#issuecomment-2146402910


More information about the build-dev mailing list