RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v30]

[Severin Gehwolf]

On Wed, 5 Jun 2024 13:54:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 113 commits:
>> 
>>  - Mark some tests with requiring packaged modules
>>  - Correctly set packaged modules default
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Fix new line in jlink.properties
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Simplify JLINK_JDK_EXTRA_OPTS var handling
>>  - Only add runtime track files for linkable runtimes
>>  - Generate the runtime image link diff at jlink time
>>    
>>    But only do that once the plugin-pipeline has run. The generation is
>>    enabled with the hidden option '--generate-linkable-runtime' and
>>    the resource pools available at jlink time are being used to generate
>>    the diff.
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - ... and 103 more: https://git.openjdk.org/jdk/compare/64bbae75...0eb1e48d
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/ResourceDiff.java line 215:
> 
>> 213:             }
>> 214:         } catch (IOException e) {
>> 215:             e.printStackTrace();
> 
> Is this IOException swallowed by jlink when not running with the debugging option? I'm wondering about the printStackTrace here.

I think this is a left-over of some devevelopment work. Removed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1628115979