RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v30]

[Severin Gehwolf]

On Wed, 5 Jun 2024 13:46:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 113 commits:
>> 
>>  - Mark some tests with requiring packaged modules
>>  - Correctly set packaged modules default
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Fix new line in jlink.properties
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - Simplify JLINK_JDK_EXTRA_OPTS var handling
>>  - Only add runtime track files for linkable runtimes
>>  - Generate the runtime image link diff at jlink time
>>    
>>    But only do that once the plugin-pipeline has run. The generation is
>>    enabled with the hidden option '--generate-linkable-runtime' and
>>    the resource pools available at jlink time are being used to generate
>>    the diff.
>>  - Merge branch 'master' into jdk-8311302-jmodless-link
>>  - ... and 103 more: https://git.openjdk.org/jdk/compare/64bbae75...0eb1e48d
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line 119:
> 
>> 117: 
>> 118: err.runtime.link.not.linkable.runtime=The current run-time image does not support run-time linking.
>> 119: err.runtime.link.jdk.jlink.prohibited=Including jdk.jlink module for run-time image based links is not allowed.
> 
> The phrase "run-time image based links" in this error message (and in the value of err.runtime.link.packaged.mods) is a bit unusual. As developers will see this message then maybe it could say that this jlink in the current run-time image doesn't contain packaged modules and cannot be used to create another run-time image that include the jdk.jlink module.

I've used alternative phrasing. Hopefully better now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1628146154