RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

Chen Liang liach at openjdk.org
Fri Jun 7 12:56:19 UTC 2024


On Fri, 7 Jun 2024 12:47:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile line 50:
>> 
>>> 48: clean:
>>> 49: 	rm -f *.class .classes
>>> 50: 
>> 
>> Hmm, shouldn't this newline at EOF be kept? Asking @ all the people who've reviewed this so far, no need to change it just yet
>
> No, it's an extra newline. A file should end with a newline but one is enough.

As confusing as they are, unfortunately GitHub UI does not render extra trailing newlines. This is the only one I could find with grepWin.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1631159094


More information about the build-dev mailing list