RFR: 8333685: Make update-copyright-year script more useful

Thomas Stuefe stuefe at openjdk.org
Tue Jun 11 12:37:12 UTC 2024


On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

> Hi all, 
> 
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685). 
> 
> I have added the following enhancements: 
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E` respectively. 
> - Altered default behaviour to limit the processed changesets to those in the current branch and the current year. 
> - Enabled an option to modify all changesets in the year if desired (this was the previous default behaviour). 
> - Added named parameters and enabled `--help`.
> - Removed mercurial support. 
> - Fixed a bug where copyright headers that didn't have a comma following the initial year of creation were not getting picked up. For example, [here](https://github.com/openjdk/jdk/blob/512b2b4f141f9a202984150b0427372e1a409a50/src/hotspot/cpu/zero/copy_zero.hpp#L3). 
> - Fixed a bug where copyright headers missing the copyright symbol (c) were not getting picked up. Refer to the example above as well. 
> 
> Thanks, 
> Sonia

Tested on Linux, there it works.

Note, IIRC, the original unpatched version also worked on MacOS. So, I think the original sed expressions were probably ok. Something about `(${copyright_symbol} )?` perhabs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19605#issuecomment-2160646983


More information about the build-dev mailing list