RFR: 8334166: Enable binary check

Kevin Rushforth kcr at openjdk.org
Wed Jun 12 22:52:13 UTC 2024


On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song <zsong at openjdk.org> wrote:

> @kevinrushforth said in [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our repositories contain source code and not binary files. There are exceptions to this for images and other similar resources, but otherwise the policy for most repos is to avoid binary files'. Skara is able to identify binary files when executing jcheck, but this check is not enabled.

How is this check presented to the PR author and Reviewers of a PR? Is it listed as a warning similar to the issue title warning?  Do you have a sample PR (Draft is fine) that would show how this looks?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19683#pullrequestreview-2114351244


More information about the build-dev mailing list