RFR: 8334166: Enable binary check

[Phil Race]

On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song <zsong at openjdk.org> wrote:

> @kevinrushforth said in [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our repositories contain source code and not binary files. There are exceptions to this for images and other similar resources, but otherwise the policy for most repos is to avoid binary files'. Skara is able to identify binary files when executing jcheck, but this check is not enabled.

> > How is this check presented to the PR author and Reviewers of a PR? Is it listed as a warning similar to the issue title warning? Do you have a sample PR (Draft is fine) that would show how this looks?
> 
> [openjdk/playground#208](https://github.com/openjdk/playground/pull/208) Here is a sample PR. Maybe we need to rephrase the warning message.

I agree, the phrasing makes it sound like a hard error, not a warning, how about 

"Binary files checked into project source repositories are strongly discouraged, you should consider alternative solutions."

But why does your example warn on a .png ? They are supposed to be allowed ..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2164061351