RFR: 8333477: Delete extra empty spaces in Makefiles [v2]
    Chen Liang 
    liach at openjdk.org
       
    Fri Jun 14 12:56:23 UTC 2024
    
    
  
On Fri, 14 Jun 2024 10:52:40 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Ah, I had not realized that there was more than 1 newline. GitHub's UI confused me here, so we're good to go
>
> GitHub's UI assumes the final line has an line break. If it is missing, it displays a red 🚫 at the end of the last line. If there is an empty line showing up in the UI, then it is an additional empty line.
In this case, GitHub is actually not showing up extra empty lines, that they appear the same as the single line break in the end of the file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1639783594
    
    
More information about the build-dev
mailing list