RFR: 8329288: Update Visual Studio visibility support for POSIX functions

Magnus Ihse Bursie ihse at openjdk.org
Tue Jun 18 12:19:32 UTC 2024


>From the JBS description:

We use various POSIX functions in the JDK in shared code, and possibly even in Windows-specific code. The UCRT optionally provides the relevant functionality under alternate names with leading underscores, and optionally provides the POSIX names and by default warns about their use.
https://learn.microsoft.com/en-us/cpp/c-runtime-library/compatibility?view=msvc-170

We currently define _CRT_NONSTDC_NO_DEPRECATE to request the POSIX names be defined and to suppress the deprecation warnings. However, that macro seems to be undocumented (or perhaps is no longer documented). Instead, recent versions of that compatibility page suggest the use of _CRT_NONSTDC_NO_WARNINGS and _CRT_DECLARE_NONSTDC_NAMES. We should update our usage accordingly.

-------------

Commit messages:
 - Remove undocumented _CRT_NONSTDC_NO_DEPRECATE
 - Refactor to extract common defines between JDK and JVM

Changes: https://git.openjdk.org/jdk/pull/19766/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19766&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329288
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/19766.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19766/head:pull/19766

PR: https://git.openjdk.org/jdk/pull/19766


More information about the build-dev mailing list