RFR: 8334166: Enable binary check
Magnus Ihse Bursie
ihse at openjdk.org
Tue Jun 18 18:04:17 UTC 2024
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song <zsong at openjdk.org> wrote:
> @kevinrushforth said in [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our repositories contain source code and not binary files. There are exceptions to this for images and other similar resources, but otherwise the policy for most repos is to avoid binary files'. Skara is able to identify binary files when executing jcheck, but this check is not enabled.
This looks much better. I think we can enable this check for the JDK repo, but let's hear what the others say as well.
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19683#pullrequestreview-2126169104
PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2176671524
More information about the build-dev
mailing list