RFR: 8334166: Enable binary check
Phil Race
prr at openjdk.org
Tue Jun 18 22:53:10 UTC 2024
On Thu, 13 Jun 2024 17:50:21 GMT, Phil Race <prr at openjdk.org> wrote:
>> @kevinrushforth said in [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our repositories contain source code and not binary files. There are exceptions to this for images and other similar resources, but otherwise the policy for most repos is to avoid binary files'. Skara is able to identify binary files when executing jcheck, but this check is not enabled.
>
> If skara really is unable to distinguish a png from an exe, then I agree the warning needs to be toned way down to an "FYI", not even a warning.
> And something less scary than the yellow triangle with a "!" as the graphic too.
> @prrace Any objections to the current version of the warning message?
Meaning this example " ⚠️ Patch contains a binary file (duke-thinking.png)"
I think that's fine.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2177214054
More information about the build-dev
mailing list