RFR: 8334618: ubsan: support setting additional ubsan check options

[Julian Waters]

On Thu, 20 Jun 2024 11:31:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Sometimes it would be helpful to have configure-support for adding additional ubsan check options.
> E.g. support new configure option '--with-additional-ubsan-checks=<check-settings>' .

I'm not very fond of adding new configure options, but I guess this is ok. A thought, rather than a raw AC_ARG_WITH, newer code should try to adopt UTIL_ARG_WITH instead, for example:


UTIL_ARG_WITH(NAME: additional-ubsan-checks, TYPE: string, DEFAULT: [], DESC: [Custom ubsan checks], OPTIONAL: true)

UBSAN_CHECKS="-fsanitize=undefined -fsanitize=float-divide-by-zero -fno-sanitize=shift-base -fno-sanitize=alignment $ADDITIONAL_UBSAN_CHECKS"


More information about UTIL_ARG_WITH and friends can be found in their implementation documentation here: https://github.com/openjdk/jdk/blob/5cad0b4df7f5ccb6d462dc948c2ea5ad5da6e2ed/make/autoconf/util.m4#L579

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19802#issuecomment-2180537138