RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack?

[Kim Barrett]

On Sat, 22 Jun 2024 13:58:32 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> fastdebug:
> 
> 
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  Internal Error (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), pid=878152, tid=878158
> #  assert(_thread->is_in_live_stack((address)this)) failed: not on stack?
> #
> # JRE version:  (24.0) (fastdebug build )
> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 24-internal-adhoc.azul.openjdk-git, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
> # Problematic frame:
> # V  [libjvm.so+0x1d20658]  constantPoolHandle::constantPoolHandle(Thread*, ConstantPool*)+0x268

Changes requested by kbarrett (Reviewer).

make/autoconf/jdk-options.m4 line 448:

> 446:           if test "x$TOOLCHAIN_TYPE" = "xclang"; then
> 447:             ASAN_CFLAGS="$ASAN_CFLAGS -fsanitize-address-use-after-return=never"
> 448:           fi

I don't think this change should be made.  Globally disabling some otherwise
likely useful asan warnings to address what looks like a localized problem
doesn't seem like a good approach to me.

Also, suppression seems inappropriate since this has the look of a possible
JVM bug. It's hard to tell without more context for the failure, like the full
stack trace and how to reproduce.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19843#pullrequestreview-2134039965
PR Review Comment: https://git.openjdk.org/jdk/pull/19843#discussion_r1649872928