RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

[David Holmes]

On Mon, 24 Jun 2024 14:34:37 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> fastdebug:
>> 
>> 
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  Internal Error (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), pid=878152, tid=878158
>> #  assert(_thread->is_in_live_stack((address)this)) failed: not on stack?
>> #
>> # JRE version:  (24.0) (fastdebug build )
>> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 24-internal-adhoc.azul.openjdk-git, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
>> # Problematic frame:
>> # V  [libjvm.so+0x1d20658]  constantPoolHandle::constantPoolHandle(Thread*, ConstantPool*)+0x268
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change the comment
>    - suggested by Thomas Stuefe

make/autoconf/jdk-options.m4 line 443:

> 441:           # detect_stack_use_after_return causes ASAN to offload stack-local
> 442:           # variables to c-heap and therefore breaks assumptions in hotspot
> 443:           # that rely on data (e.g. Marks) living in thread stacks.

Ah! Now I understand what it is doing. Ouch!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19843#discussion_r1652118073