RFR: 8329816: Add SLEEF version 3.6.1 [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Jun 27 22:00:51 UTC 2024
On Thu, 27 Jun 2024 21:56:19 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to optimize vector math operations by leveraging the SLEEF library. For legal reasons the actual contribution of the SLEEF files needs to be handled separately. This enhancement adds the relevant files, enabling the rest of [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward.
>
> Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Add SLEEF version 3.6.1
> - Merge branch 'master' into 8329816-sleef
> - 8329816: Add SLEEF version 3.6
make/devkit/createSleef.sh line 32:
> 30: #
> 31: # 1. cd <sleef>
> 32: # 2. bash <jdk>/make/devkit/createSleef.sh aarch64-gcc.cmake <path-to>/devkit
So you'd need a different copy of sleef for each platform? The files you have put in `linux/native/libvectormath`, what platform are they for? Should we not put them in a platform-specific subdirectory?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19185#discussion_r1609623756
More information about the build-dev
mailing list