RFR: 8329816: Add SLEEF version 3.6.1 [v2]
Hamlin Li
mli at openjdk.org
Thu Jun 27 22:00:52 UTC 2024
On Thu, 23 May 2024 10:40:26 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>>> So you'd need a different copy of sleef for each platform?
>>
>> I think it's one or more.
>>
>>> The files you have put in linux/native/libvectormath, what platform are they for? Should we not put them in a platform-specific subdirectory?
>>
>> we could, but not necessary, as long as they have different suffixes, and normally that suffixes indicate what platform it's for.
>
> Okay, suffix works fine too. But the files currently in the patch is named e.g. `sleefinline_advsimd.h`, which does not indicate any platform at all. Is it a generic file, and the platform specific ones are still missing from this PR?
I think both `sleefinline_advsimd.h` and `sleefinline_sve.h` are specific for arm.
In the future, on riscv the corresponding file name will be `sleefinline_rvvm1.h`.
Only `misc.h` is a generic file shared among platforms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19185#discussion_r1611636701
More information about the build-dev
mailing list