RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v9]

Jorn Vernee jvernee at openjdk.org
Fri Jun 28 19:43:36 UTC 2024


On Fri, 28 Jun 2024 16:47:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   de-dupe on path, not module name
>
> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/JNativeScanTask.java line 105:
> 
>> 103:                     for (String classPathEntry : classPathAttribute) {
>> 104:                         Path otherJar = parentDir != null
>> 105:                                 ? parentDir.resolve(classPathEntry)
> 
> We'lll need to create a follow on issue to re-examine this as the value of a Class-Path attribute aren't sequence of relative URIs (with an optional "file" URI scheme) rather than file paths. Treating it as a file path may work in some cases but won't work once you encounter cases that use escaping.

Okay, it seems that I didn't read the spec careful enough, and filtering valid URLs in the Class-Path attribute is actually a bit tricky. Let's handle this in a follow up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19774#discussion_r1659242843


More information about the build-dev mailing list