RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v10]

[Chen Liang]

On Fri, 28 Jun 2024 19:43:36 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find code that accesses native functionality. Currently this includes `native` method declarations, and methods marked with `@Restricted`.
>> 
>> The tool accepts a list of class path and module path entries through `--class-path` and `--module-path`, and a set of root modules through `--add-modules`, as well as an optional target release with `--release`.
>> 
>> The default mode is for the tool to report all uses of `@Restricted` methods, and `native` method declaration in a tree-like structure:
>> 
>> 
>> app.jar (ALL-UNNAMED):
>>   main.Main:
>>     main.Main::main(String[])void references restricted methods:
>>       java.lang.foreign.MemorySegment::reinterpret(long)MemorySegment
>>     main.Main::m()void is a native method declaration
>> 
>> 
>> The `--print-native-access` option can be used print out all the module names of modules doing native access in a comma separated list. For class path code, this will print out `ALL-UNNAMED`.
>> 
>> Testing: 
>> - `langtools_jnativescan` tests.
>> - Running the tool over jextract's libclang bindings, which use the FFM API, and thus has a lot of references to `@Restricted` methods.
>> - tier 1-3
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use instance resolveAndBind + use junit in tests

src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/MethodRef.java line 38:

> 36:     }
> 37: 
> 38:     public static MethodRef ofMemberRefEntry(MemberRefEntry method) {

I recommend to change this to `ofInvokeInstruction`:

public static MethodRef ofInvokeInstruction(InvokeInstruction instruction) {
    return new MethodRef(instruction.owner().asSymbol(),
            instruction.name().stringValue(), instruction.typeSymbol());
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19774#discussion_r1659345527