RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries [v2]
    Magnus Ihse Bursie 
    ihse at openjdk.org
       
    Mon Mar  4 15:00:07 UTC 2024
    
    
  
On Sun, 3 Mar 2024 22:12:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use @requires in test
>
> make/autoconf/flags-cflags.m4 line 40:
> 
>> 38:     # Default works for linux, might work on other platforms as well.
>> 39:     SHARED_LIBRARY_FLAGS='-shared'
>> 40:     SET_EXECUTABLE_ORIGIN='-Wl,-rpath,\$$ORIGIN[$]1 -Wl,--disable-new-dtags'
> 
> The reason we use `--disable-new-dtags` needs to be documented somewhere.
I agree. A short description and a reference to this bug number would be nice.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18050#discussion_r1511290973
    
    
More information about the build-dev
mailing list