RFR: 8327218: Add an ability to specify modules which should have native access enabled [v3]

[Jan Lahoda]

On Thu, 7 Mar 2024 09:30:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/native-access-modules1' into native-access-modules1
>>  - Reflecting review feedback.
>>  - Updating copyright headers.
>
> src/java.base/share/classes/java/lang/ModuleLayer.java line 891:
> 
>> 889:      *         {@code false} otherwise
>> 890:      */
>> 891:     boolean addEnableNativeAccess(String name) {
> 
> Do you mind changing the method description to "Updates the module with the given name in this layer to allow access to restricted methods"? This will be keep it more consistent with the exiting methods.
> 
> Also "was present" in the return description hints that it may not now be present. A module layer is immutable so it can just say that it returns true if the  module is in this layer.

Adjusted here:
https://github.com/openjdk/jdk/pull/18106/commits/6af399ee4a3e908cb7c6b983b9747310e23a888e
please let me know if further/other changes/adjustment are desirable.

Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18106#discussion_r1516878109