RFR: 8327675: jspawnhelper should be built on all unix platforms
Erik Joelsson
erikj at openjdk.org
Fri Mar 8 14:00:53 UTC 2024
On Fri, 8 Mar 2024 10:17:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> We should match the building of jspawnhelper in make/modules/java.base/Launcher.gmk with the usage for all unix platforms in src/java.base/unix/classes/java/lang/ProcessImpl.java.
>
> Granted, the list of OSes in the makefile amounts to the current list of all Unix OSes in the JDK, but there is no need to have this logical disparity.
>
> This was inspired by the discovery in https://github.com/openjdk/jdk/pull/18112#discussion_r1517455696.
Looks good, but why are the tests failing?
-------------
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18165#pullrequestreview-1924937739
More information about the build-dev
mailing list